[PATCH] D55963: [pstl] Initial integration with LLVM's CMake
Mikhail Dvorskiy via Phabricator
reviews at reviews.llvm.org
Fri Dec 21 03:25:03 PST 2018
MikeDvorskiy added inline comments.
Comment at: pstl/cmake/FindTBB.cmake:12
-# Firstly search for TBB in config mode (i.e. search for TBBConfig.cmake).
-find_package(TBB QUIET CONFIG)
> This is required because otherwise they look for both the release and the Debug version of TBB, and we don't find anything if both are not provided. The rest of `FindTBB.cmake` handles this properly, so I'm not sure why they even try to defer to the `TBBConfig.cmake`.
Yes, the changes may be accepted, at least till the TBBConfig.cmake will not require both Release and Debug TBB.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits