[PATCH] D55963: [pstl] Initial integration with LLVM's CMake
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Fri Dec 21 08:02:43 PST 2018
ldionne accepted this revision.
ldionne marked an inline comment as done.
ldionne added a comment.
This revision is now accepted and ready to land.
@jfb is on vacation, going forward. This is really more for exposition than anything anyway, since this is to get some testing going.
Comment at: pstl/cmake/FindTBB.cmake:12
-# Firstly search for TBB in config mode (i.e. search for TBBConfig.cmake).
-find_package(TBB QUIET CONFIG)
> ldionne wrote:
> > This is required because otherwise they look for both the release and the Debug version of TBB, and we don't find anything if both are not provided. The rest of `FindTBB.cmake` handles this properly, so I'm not sure why they even try to defer to the `TBBConfig.cmake`.
> Yes, the changes may be accepted, at least till the TBBConfig.cmake will not require both Release and Debug TBB.
Please consider chiming in here: https://github.com/01org/tbb/issues/113
CHANGES SINCE LAST ACTION
More information about the libcxx-commits