[PATCH] D55517: Remove `_VSTD`
JF Bastien via Phabricator
reviews at reviews.llvm.org
Mon Dec 10 12:16:52 PST 2018
jfb added a comment.
In D55517#1325994 <https://reviews.llvm.org/D55517#1325994>, @EricWF wrote:
> In D55517#1325917 <https://reviews.llvm.org/D55517#1325917>, @jfb wrote:
> > I think your commit message is fun and terse, but it doesn't say why you're actually correct. You're explaining it here, Marshall has voiced concerns about downsides. I think your commit message should explain this and say why you think the downsides aren't relevant. That makes it easier to go back to your change in the future and understand why the change was OK without looking at this discussion.
> How's the new commit message?
Looks great, ty!
CHANGES SINCE LAST ACTION
More information about the libcxx-commits