[PATCH] D55517: Remove `_VSTD`

Olivier Giroux via Phabricator reviews at reviews.llvm.org
Mon Dec 10 14:16:07 PST 2018


__simt__ added a comment.

Hello Eric, everyone else,

We have projects that are getting great mileage from this macro right now, we'd be sad to see it go. 😰

If you look at https://github.com/ogiroux/freestanding you'll get the gist of what we're doing with it: //we don't just change the inline namespace name, we also change the// `std::` //namespace name using the macro//. This was never the intended use, I realize, but it allows us to make progress with e.g. side-by-side co-existence for a large & important subset. In other words, the presence of this macro helped make libc++ adaptable the way needed it to be, and may slowly transform us into contributors even (hence netting you great mileage too).

So our view is that we would not like to see this change made. Sorry.

Olivier


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55517/new/

https://reviews.llvm.org/D55517





More information about the libcxx-commits mailing list