[PATCH] D55308: Implement the second part of P0482 (char8_t)

Marshall Clow via Phabricator reviews at reviews.llvm.org
Fri Dec 7 09:48:30 PST 2018


mclow.lists added a comment.

In D55308#1323439 <https://reviews.llvm.org/D55308#1323439>, @mclow.lists wrote:

> In D55308#1321975 <https://reviews.llvm.org/D55308#1321975>, @ldionne wrote:
>
> > But it would be nice to extract this check into a separate utility header to avoid duplication.
>
>
> I don't think that's a good idea; that header would quickly grow into all the tests for all the feature flags.
>  But I'm willing to discuss that.


Or at least all the tests for all the feature flags that have to support more than one header.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55308/new/

https://reviews.llvm.org/D55308





More information about the libcxx-commits mailing list