[PATCH] D55308: Implement the second part of P0482 (char8_t)

Marshall Clow via Phabricator reviews at reviews.llvm.org
Fri Dec 7 13:36:04 PST 2018


mclow.lists marked 4 inline comments as done.
mclow.lists added inline comments.


================
Comment at: test/std/language.support/support.limits/support.limits.general/limits.version.pass.cpp:18
+
+#include <string_view>
+#include <cassert>
----------------
ldionne wrote:
> ldionne wrote:
> > `<limits>`
> Still wrong?
Fixed locally.


================
Comment at: test/std/language.support/support.limits/support.limits.general/locale.version.pass.cpp:18
+
+#include <string_view>
+#include <cassert>
----------------
ldionne wrote:
> ldionne wrote:
> > `<locale>`
> Still wrong?
Fixed locally.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55308/new/

https://reviews.llvm.org/D55308





More information about the libcxx-commits mailing list