[libc-commits] [PATCH] D75651: [libc] [UnitTest] Add timeout to death tests

Alex Brachet via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Mar 4 15:11:40 PST 2020


abrachet created this revision.
abrachet added reviewers: sivachandra, MaskRay, gchatelet, PaulkaToast.
Herald added a subscriber: tschuett.

This patch adds a timeout of 500ms to death tests. As we add multithreaded code and locks, deadlocks become more likely so timeout will be useful.

Additionally:

- Better error handling in `invokeSubprocess`
- Makes `ProcessStatus`'s methods const


https://reviews.llvm.org/D75651

Files:
  libc/utils/UnitTest/Test.cpp
  libc/utils/testutils/ExecuteFunction.h
  libc/utils/testutils/ExecuteFunctionUnix.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75651.248331.patch
Type: text/x-patch
Size: 4359 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200304/01ecac84/attachment.bin>


More information about the libc-commits mailing list