[flang-commits] [PATCH] D158957: [flang][runtime] Avoid dependency on libc++ for `std::__libcpp_verbose_abort`

[Martin Storsjö via Phabricator via flang-commits]

mstorsjo added a comment.

In D158957#4620947 <https://reviews.llvm.org/D158957#4620947>, @mmuetzel wrote:

> Would it help to add a TODO comment that this is just a work-around for the more general issue?

I'd leave that up to Flang maintainers (I'm not really involved enough to have a say in that) whether this is a reasonable thing to do, or what the right way forward is.

In D158957#4620969 <https://reviews.llvm.org/D158957#4620969>, @mmuetzel wrote:

> Still fails in the CI with:
>
> Maybe, I misinterpreted that error.
> Why does it reportedly work for MinGW?
>
> I basically copied the example from the libc++ documentation. Does that documentation need an update?

There's no guarantee that that CI instance runs with the latest libc++ - it may be running on an older installation of Clang/libc++ that doesn't have `__libcpp_verbose_abort` yet. Or it might be running on top of libstdc++?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158957/new/

https://reviews.llvm.org/D158957