[flang-commits] [PATCH] D158957: [flang][runtime] Avoid dependency on libc++ for `std::__libcpp_verbose_abort`

[Markus Mützel via Phabricator via flang-commits]

mmuetzel added a comment.

Still fails in the CI with:

  [1606/4861] Building CXX object tools/flang/runtime/CMakeFiles/obj.FortranRuntime.dir/io-api.cpp.o
  FAILED: tools/flang/runtime/CMakeFiles/obj.FortranRuntime.dir/io-api.cpp.o
  CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DBUILD_EXAMPLES -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_LIBCPP_ENABLE_HARDENED_MODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/lib/buildkite-agent/builds/llvm-project/build/tools/flang/runtime -I/var/lib/buildkite-agent/builds/llvm-project/flang/runtime -I/var/lib/buildkite-agent/builds/llvm-project/flang/include -I/var/lib/buildkite-agent/builds/llvm-project/build/tools/flang/include -I/var/lib/buildkite-agent/builds/llvm-project/build/include -I/var/lib/buildkite-agent/builds/llvm-project/llvm/include -isystem /var/lib/buildkite-agent/builds/llvm-project/llvm/../mlir/include -isystem /var/lib/buildkite-agent/builds/llvm-project/build/tools/mlir/include -isystem /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/include -isystem /var/lib/buildkite-agent/builds/llvm-project/llvm/../clang/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -fno-lto -O3 -DNDEBUG   -U_GLIBCXX_ASSERTIONS -U_LIBCPP_ENABLE_ASSERTIONS -UNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/flang/runtime/CMakeFiles/obj.FortranRuntime.dir/io-api.cpp.o -MF tools/flang/runtime/CMakeFiles/obj.FortranRuntime.dir/io-api.cpp.o.d -o tools/flang/runtime/CMakeFiles/obj.FortranRuntime.dir/io-api.cpp.o -c /var/lib/buildkite-agent/builds/llvm-project/flang/runtime/io-api.cpp
  /var/lib/buildkite-agent/builds/llvm-project/flang/runtime/io-api.cpp:1523:11: error: out-of-line definition of '__libcpp_verbose_abort' does not match any declaration in namespace 'std'
  void std::__libcpp_verbose_abort(char const* format, ...) {
            ^~~~~~~~~~~~~~~~~~~~~~
  1 error generated.

Maybe, I misinterpreted that error.
Why does it reportedly work for MinGW?

I basically copied the example from the libc++ documentation. Does that documentation need an update?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158957/new/

https://reviews.llvm.org/D158957