[cfe-dev] cfe-commits@ now automatically subscribed to Clang review requests

Ben Hamilton via cfe-dev cfe-dev at lists.llvm.org
Mon Nov 27 11:34:12 PST 2017


It should work both when submitting revisions via the arc command-line and
via the Differential web interface.

I'm not aware of any other ways to send out review requests for Clang, but
let me know if there are any I missed. :)

Ben

On Mon, Nov 27, 2017 at 12:19 PM George Karpenkov <ekarpenkov at apple.com>
wrote:

> Great!
> This only works when submitting revisions via arc, right?
>
>
> On Nov 27, 2017, at 11:00 AM, Ben Hamilton via cfe-dev <
> cfe-dev at lists.llvm.org> wrote:
>
> I landed D40494 <https://reviews.llvm.org/D40494> today, which enables
> Herald rule H268 <https://reviews.llvm.org/H268> to automatically
> subscribe cfe-commits at lists.llvm.org to any review requests sent out in
> the Clang repository.
>
> Specifically, after syncing to SVN revision 319052
> <https://reviews.llvm.org/rL319052> / git commit 64881a00, any review
> requests will automatically subscribe cfe-commits@ — you no longer have
> to remember to manually add this to each review request.
>
> I also landed D40180 <https://reviews.llvm.org/D40180>, which does the
> same thing for clang-tools-extra. Once D40500
> <https://reviews.llvm.org/D40500> and D40501
> <https://reviews.llvm.org/D40501> land, they will also do this for libc++
> and libc++abi reviews.
>
> If you want to opt out of this feature, just add [private] to your
> revision title. (Note that review requests are still visible in
> Differential; this just disables copying cfe-commits at .)
>
> Thanks,
>
> Ben
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20171127/4710f95f/attachment.html>


More information about the cfe-dev mailing list