<div dir="ltr">It should work both when submitting revisions via the arc command-line and via the Differential web interface.<div><br></div><div>I'm not aware of any other ways to send out review requests for Clang, but let me know if there are any I missed. :)</div><div><br>Ben</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Nov 27, 2017 at 12:19 PM George Karpenkov <<a href="mailto:ekarpenkov@apple.com">ekarpenkov@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">Great!<div>This only works when submitting revisions via arc, right?</div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><br><div><br><blockquote type="cite"><div>On Nov 27, 2017, at 11:00 AM, Ben Hamilton via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:</div><br class="m_-3194556255280280862Apple-interchange-newline"><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">I landed<span class="m_-3194556255280280862Apple-converted-space"> </span><a href="https://reviews.llvm.org/D40494" target="_blank">D40494</a><span class="m_-3194556255280280862Apple-converted-space"> </span>today, which enables Herald rule<span class="m_-3194556255280280862Apple-converted-space"> </span><a href="https://reviews.llvm.org/H268" target="_blank">H268</a> to automatically subscribe <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a> to any review requests sent out in the Clang repository.<div><br></div><div>Specifically, after syncing to SVN revision<span class="m_-3194556255280280862Apple-converted-space"> </span><a href="https://reviews.llvm.org/rL319052" target="_blank">319052</a> / git commit 64881a00, any review requests will automatically subscribe cfe-commits@ — you no longer have to remember to manually add this to each review request.</div><div><br></div><div>I also landed <a href="https://reviews.llvm.org/D40180" target="_blank">D40180</a>, which does the same thing for clang-tools-extra. Once<span class="m_-3194556255280280862Apple-converted-space"> </span><a href="https://reviews.llvm.org/D40500" target="_blank">D40500</a><span class="m_-3194556255280280862Apple-converted-space"> </span>and<span class="m_-3194556255280280862Apple-converted-space"> </span><a href="https://reviews.llvm.org/D40501" target="_blank">D40501</a><span class="m_-3194556255280280862Apple-converted-space"> </span>land, they will also do this for libc++ and libc++abi reviews.</div><div><br></div><div>If you want to opt out of this feature, just add [private] to your revision title. (Note that review requests are still visible in Differential; this just disables copying cfe-commits@.)</div><div><br></div><div>Thanks,</div><div><br></div><div>Ben</div></div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important"></span><br class="m_-3194556255280280862Apple-interchange-newline"></div></blockquote></div><br></div></div></blockquote></div>