[cfe-dev] [Proposal] Automatically Cc: cfe-commits@ on Clang reviews

Stephan Bergmann via cfe-dev cfe-dev at lists.llvm.org
Tue Nov 21 07:00:35 PST 2017


On 11/21/2017 03:41 PM, Ben Hamilton wrote:
>  > My understanding was that, while there currently is no official 
> monorepo, it is at least possible and accepted to send single, 
> cross-repo patches for review.  That would no longer be possible, right?
> 
> I assume cross-repo patches would be constructed by hand, right? Or do 
> you mean using the unofficial monorepo from 2016 
> <https://github.com/joker-eph/llvm-project>?

I'm using <https://github.com/llvm-project/llvm-project-20170507> (as 
advertised at 
<https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo>), 
where such a "cross-repo diff" is just a matter of a plain 'git diff'.

> An example of an existing cross-repo review in Differential would be 
> nice—do you happen to have one handy?

I just happened to file <https://reviews.llvm.org/D40295> a moment ago, 
spanning clang and compiler-rt.

> I think either way, we'd keep the ability to send cross-repo patches to 
> the top-level LLVM repo just the same way you could today.
> 
> I'll confirm that if you can help me construct an example cross-repo 
> patch for review.

Thanks,
Stephan


More information about the cfe-dev mailing list