[cfe-dev] [libcxx] r280773 - Enable installation of libc++experimental by default.

Eric Fiselier via cfe-dev cfe-dev at lists.llvm.org
Tue Sep 6 18:29:45 PDT 2016


FYI libc++experimental.a is now installed by default. Users and vendors who
wish to disable this must manually specify
-DLIBCXX_INSTALL_EXPERIMENTAL_LIBRARY=OFF.

/Eric

On Tue, Sep 6, 2016 at 7:15 PM, Eric Fiselier via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Author: ericwf
> Date: Tue Sep  6 20:15:10 2016
> New Revision: 280773
>
> URL: http://llvm.org/viewvc/llvm-project?rev=280773&view=rev
> Log:
> Enable installation of libc++experimental by default.
>
> When libc++experimental was originally created it was empty and therefore
> there
> was no reason to install it. Now that the library contains
> <experimental/memory_resource> and <experimental/filesystem> there is a
> good
> reason to install it.
>
> Specifically this patch enables the installation whenever
> LIBCXX_INSTALL_LIBRARY
> is true and LIBCPP_ENABLE_EXPERIMENTAL_LIBRARY is true.
>
> Modified:
>     libcxx/trunk/CMakeLists.txt
>     libcxx/trunk/docs/BuildingLibcxx.rst
>
> Modified: libcxx/trunk/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/
> CMakeLists.txt?rev=280773&r1=280772&r2=280773&view=diff
> ============================================================
> ==================
> --- libcxx/trunk/CMakeLists.txt (original)
> +++ libcxx/trunk/CMakeLists.txt Tue Sep  6 20:15:10 2016
> @@ -48,6 +48,7 @@ MACRO_ENSURE_OUT_OF_SOURCE_BUILD(
>  #===========================================================
> ====================
>  # Setup CMake Options
>  #===========================================================
> ====================
> +include(CMakeDependentOption)
>
>  # Basic options ------------------------------
> ---------------------------------
>  option(LIBCXX_ENABLE_ASSERTIONS "Enable assertions independent of build
> mode." ON)
> @@ -65,7 +66,9 @@ set(LIBCXX_LIBDIR_SUFFIX "${LLVM_LIBDIR_
>  option(LIBCXX_INSTALL_HEADERS "Install the libc++ headers." ON)
>  option(LIBCXX_INSTALL_LIBRARY "Install the libc++ library." ON)
>  option(LIBCXX_INSTALL_SUPPORT_HEADERS "Install libc++ support headers."
> ON)
> -option(LIBCXX_INSTALL_EXPERIMENTAL_LIBRARY "Install
> libc++experimental.a" OFF)
> +cmake_dependent_option(LIBCXX_INSTALL_EXPERIMENTAL_LIBRARY
> +        "Install libc++experimental.a" ON
> +        "LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY;LIBCXX_INSTALL_LIBRARY" OFF)
>  set(LIBCXX_ABI_VERSION 1 CACHE STRING "ABI version of libc++.")
>  option(LIBCXX_ABI_UNSTABLE "Unstable ABI of libc++." OFF)
>  option(LIBCXX_USE_COMPILER_RT "Use compiler-rt instead of libgcc" OFF)
>
> Modified: libcxx/trunk/docs/BuildingLibcxx.rst
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/docs/
> BuildingLibcxx.rst?rev=280773&r1=280772&r2=280773&view=diff
> ============================================================
> ==================
> --- libcxx/trunk/docs/BuildingLibcxx.rst (original)
> +++ libcxx/trunk/docs/BuildingLibcxx.rst Tue Sep  6 20:15:10 2016
> @@ -179,7 +179,7 @@ libc++experimental Specific Options
>
>  .. option:: LIBCXX_INSTALL_EXPERIMENTAL_LIBRARY:BOOL
>
> -  **Default**: ``OFF``
> +  **Default**: ``LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY AND
> LIBCXX_INSTALL_LIBRARY``
>
>    Install libc++experimental.a alongside libc++.
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20160906/0063b11e/attachment.html>


More information about the cfe-dev mailing list