<div dir="ltr">FYI libc++experimental.a is now installed by default. Users and vendors who wish to disable this must manually specify -DLIBCXX_INSTALL_EXPERIMENTAL_LIBRARY=OFF.<div><br></div><div>/Eric</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 6, 2016 at 7:15 PM, Eric Fiselier via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ericwf<br>
Date: Tue Sep  6 20:15:10 2016<br>
New Revision: 280773<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=280773&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=280773&view=rev</a><br>
Log:<br>
Enable installation of libc++experimental by default.<br>
<br>
When libc++experimental was originally created it was empty and therefore there<br>
was no reason to install it. Now that the library contains<br>
<experimental/memory_resource> and <experimental/filesystem> there is a good<br>
reason to install it.<br>
<br>
Specifically this patch enables the installation whenever LIBCXX_INSTALL_LIBRARY<br>
is true and LIBCPP_ENABLE_EXPERIMENTAL_<wbr>LIBRARY is true.<br>
<br>
Modified:<br>
    libcxx/trunk/CMakeLists.txt<br>
    libcxx/trunk/docs/<wbr>BuildingLibcxx.rst<br>
<br>
Modified: libcxx/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=280773&r1=280772&r2=280773&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/<wbr>CMakeLists.txt?rev=280773&r1=<wbr>280772&r2=280773&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/CMakeLists.txt (original)<br>
+++ libcxx/trunk/CMakeLists.txt Tue Sep  6 20:15:10 2016<br>
@@ -48,6 +48,7 @@ MACRO_ENSURE_OUT_OF_SOURCE_<wbr>BUILD(<br>
 #=============================<wbr>==============================<wbr>====================<br>
 # Setup CMake Options<br>
 #=============================<wbr>==============================<wbr>====================<br>
+include(CMakeDependentOption)<br>
<br>
 # Basic options ------------------------------<wbr>------------------------------<wbr>---<br>
 option(LIBCXX_ENABLE_<wbr>ASSERTIONS "Enable assertions independent of build mode." ON)<br>
@@ -65,7 +66,9 @@ set(LIBCXX_LIBDIR_SUFFIX "${LLVM_LIBDIR_<br>
 option(LIBCXX_INSTALL_HEADERS "Install the libc++ headers." ON)<br>
 option(LIBCXX_INSTALL_LIBRARY "Install the libc++ library." ON)<br>
 option(LIBCXX_INSTALL_SUPPORT_<wbr>HEADERS "Install libc++ support headers." ON)<br>
-option(LIBCXX_INSTALL_<wbr>EXPERIMENTAL_LIBRARY "Install libc++experimental.a" OFF)<br>
+cmake_dependent_option(<wbr>LIBCXX_INSTALL_EXPERIMENTAL_<wbr>LIBRARY<br>
+        "Install libc++experimental.a" ON<br>
+        "LIBCXX_ENABLE_EXPERIMENTAL_<wbr>LIBRARY;LIBCXX_INSTALL_<wbr>LIBRARY" OFF)<br>
 set(LIBCXX_ABI_VERSION 1 CACHE STRING "ABI version of libc++.")<br>
 option(LIBCXX_ABI_UNSTABLE "Unstable ABI of libc++." OFF)<br>
 option(LIBCXX_USE_COMPILER_RT "Use compiler-rt instead of libgcc" OFF)<br>
<br>
Modified: libcxx/trunk/docs/<wbr>BuildingLibcxx.rst<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/docs/BuildingLibcxx.rst?rev=280773&r1=280772&r2=280773&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/docs/<wbr>BuildingLibcxx.rst?rev=280773&<wbr>r1=280772&r2=280773&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/docs/<wbr>BuildingLibcxx.rst (original)<br>
+++ libcxx/trunk/docs/<wbr>BuildingLibcxx.rst Tue Sep  6 20:15:10 2016<br>
@@ -179,7 +179,7 @@ libc++experimental Specific Options<br>
<br>
 .. option:: LIBCXX_INSTALL_EXPERIMENTAL_<wbr>LIBRARY:BOOL<br>
<br>
-  **Default**: ``OFF``<br>
+  **Default**: ``LIBCXX_ENABLE_EXPERIMENTAL_<wbr>LIBRARY AND LIBCXX_INSTALL_LIBRARY``<br>
<br>
   Install libc++experimental.a alongside libc++.<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>