[cfe-dev] Ranges for diagnostics

Jordan Rose jordan_rose at apple.com
Fri Jan 24 10:40:32 PST 2014


On Jan 24, 2014, at 8:25, David Blaikie <dblaikie at gmail.com> wrote:

> If we decide that's the right direction (that all diagnostic locations should highlight the entire token, rather than just use a caret to point to the start) we should probably just fix the diagnostic printer, rather than fixing every diagnostic call site.
> 

That's not the right thing to do; sometimes a single location is a character location that may point to the start of a token, and sometimes it's a token location. That's the trouble with using SourceLocation for both of those.

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20140124/c2a24c47/attachment.html>


More information about the cfe-dev mailing list