<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jan 24, 2014, at 8:25, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">If we decide that's the right direction (that all diagnostic locations should highlight the entire token, rather than just use a caret to point to the start) we should probably just fix the diagnostic printer, rather than fixing every diagnostic call site.</div><br class="Apple-interchange-newline"></blockquote></div><br><div>That's not the right thing to do; sometimes a single location is a character location that may point to the start of a token, and sometimes it's a token location. That's the trouble with using SourceLocation for both of those.</div><div><br></div><div>Jordan</div></body></html>