[cfe-dev] Can't build ASAN tests on i586 without SSE2

[İsmail Dönmez]

Compiles fine. Please merge to release_34. There are some test errors but
those look unrelated. Will report those.

Thanks.


On Wed, Dec 4, 2013 at 2:53 PM, Kostya Serebryany <kcc at google.com> wrote:

> Please check if this patch works for you in 3.4:
> Index: lib/asan/tests/asan_test.cc
> ===================================================================
> --- lib/asan/tests/asan_test.cc (revision 196375)
> +++ lib/asan/tests/asan_test.cc (working copy)
> @@ -669,7 +669,8 @@
>    PTHREAD_JOIN(t, 0);
>  }
>
> -#if defined(__i386__) || defined(__x86_64__)
> +#if defined(__i686__) || defined(__x86_64__)
> +#include <emmintrin.h>
>  TEST(AddressSanitizer, Store128Test) {
>    char *a = Ident((char*)malloc(Ident(12)));
>    char *p = a;
> Index: lib/asan/tests/asan_test_utils.h
> ===================================================================
> --- lib/asan/tests/asan_test_utils.h    (revision 196375)
> +++ lib/asan/tests/asan_test_utils.h    (working copy)
> @@ -41,10 +41,6 @@
>  #include <unistd.h>
>  #endif
>
> -#if defined(__i386__) || defined(__x86_64__)
> -#include <emmintrin.h>
> -#endif
> -
>  #ifndef __APPLE__
>  #include <malloc.h>
>  #endif
>
>
>
> On Wed, Dec 4, 2013 at 3:04 PM, İsmail Dönmez <ismail at donmez.ws> wrote:
>
>>
>>
>>
>> On Wed, Dec 4, 2013 at 1:02 PM, Kostya Serebryany <kcc at google.com> wrote:
>>
>>>
>>>
>>>
>>> On Wed, Dec 4, 2013 at 2:56 PM, İsmail Dönmez <ismail at donmez.ws> wrote:
>>>
>>>>
>>>>
>>>>
>>>> On Wed, Dec 4, 2013 at 12:54 PM, Kostya Serebryany <kcc at google.com>wrote:
>>>>
>>>>> __i686__ sounds quite reasonable, try r196375.
>>>>>
>>>>
>>>> Please merge to release_34 :)
>>>>
>>>
>>> Can you do this?  In case you need owner's approval (mine) you've got
>>> it.
>>>
>>>
>> Sorry I have no commit access. However, I am testing it the __i686__
>> change and will report back success/failure.
>>
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20131204/7557c953/attachment.html>