<div dir="ltr">Compiles fine. Please merge to release_34. There are some test errors but those look unrelated. Will report those.<div><br></div><div>Thanks.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Dec 4, 2013 at 2:53 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Please check if this patch works for you in 3.4:<div><div>Index: lib/asan/tests/asan_test.cc</div><div>===================================================================</div><div>--- lib/asan/tests/asan_test.cc (revision 196375)</div>
<div>+++ lib/asan/tests/asan_test.cc (working copy)</div><div>@@ -669,7 +669,8 @@</div><div class="im"><div> PTHREAD_JOIN(t, 0);</div><div> }</div><div> </div><div>-#if defined(__i386__) || defined(__x86_64__)</div></div>
<div>+#if defined(__i686__) || defined(__x86_64__)</div><div class="im">
<div>+#include <emmintrin.h></div><div> TEST(AddressSanitizer, Store128Test) {</div><div> char *a = Ident((char*)malloc(Ident(12)));</div><div> char *p = a;</div></div><div>Index: lib/asan/tests/asan_test_utils.h</div>
<div>===================================================================</div><div>--- lib/asan/tests/asan_test_utils.h (revision 196375)</div><div>+++ lib/asan/tests/asan_test_utils.h (working copy)</div><div class="im">
<div>@@ -41,10 +41,6 @@</div>
<div> #include <unistd.h></div><div> #endif</div><div> </div><div>-#if defined(__i386__) || defined(__x86_64__)</div><div>-#include <emmintrin.h></div><div>-#endif</div><div>-</div><div> #ifndef __APPLE__</div>
<div> #include <malloc.h></div><div> #endif</div></div></div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 4, 2013 at 3:04 PM, İsmail Dönmez <span dir="ltr"><<a href="mailto:ismail@donmez.ws" target="_blank">ismail@donmez.ws</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Wed, Dec 4, 2013 at 1:02 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Wed, Dec 4, 2013 at 2:56 PM, İsmail Dönmez <span dir="ltr"><<a href="mailto:ismail@donmez.ws" target="_blank">ismail@donmez.ws</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div>On Wed, Dec 4, 2013 at 12:54 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">__i686__ sounds quite reasonable, try r196375.</div></blockquote><div><br></div></div><div>Please merge to release_34 :)</div>
</div></div></div></blockquote><div><br></div></div></div><div>Can you do this? In case you need owner's approval (mine) you've got it. </div><div><br></div></div></div></div></blockquote><div><br></div></div></div>
<div>Sorry I have no commit access. However, I am testing it the __i686__ change and will report back success/failure.</div>
<div><br></div><div> </div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>