[cfe-dev] removing code duplication in RecursiveASTVisitor.h

Zhanyong Wan (λx.x x) wan at google.com
Thu Jun 10 10:18:49 PDT 2010


Hi,

I uploaded a patch to http://codereview.appspot.com/1653043 to avoid
repeating the lists of operators twice in RecursiveASTVisitor.h.  This
should make the code easier to maintain, but we no longer need to
worry about the duplicates going out of sync.  What do you think?

Chandler and I discussed the option of generating the list from a .td
file.  I'm fine with that idea, but prefer to wait for the list to be
needed at another place before doing that.  Thoughts?  Thanks,

-- 
Zhanyong



More information about the cfe-dev mailing list