[cfe-dev] removing code duplication in RecursiveASTVisitor.h

Chandler Carruth chandlerc at google.com
Thu Jun 10 16:30:32 PDT 2010


I've committed this as r105796. We can factor these out to tablegen files if
there is a desire to do so in a subsequent patch.

On Thu, Jun 10, 2010 at 10:18 AM, Zhanyong Wan (λx.x x) <wan at google.com>wrote:

> Hi,
>
> I uploaded a patch to http://codereview.appspot.com/1653043 to avoid
> repeating the lists of operators twice in RecursiveASTVisitor.h.  This
> should make the code easier to maintain, but we no longer need to
> worry about the duplicates going out of sync.  What do you think?
>
> Chandler and I discussed the option of generating the list from a .td
> file.  I'm fine with that idea, but prefer to wait for the list to be
> needed at another place before doing that.  Thoughts?  Thanks,
>
> --
> Zhanyong
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100610/ed11b9bb/attachment.html>


More information about the cfe-dev mailing list