[cfe-dev] Move InitializePreprocessor() to lib/Frontend from clang-cc

[Alexei Svitkine]

Done.

On Tue, Apr 21, 2009 at 1:26 AM, Chris Lattner <clattner at apple.com> wrote:

>
> On Apr 20, 2009, at 10:15 PM, Alexei Svitkine wrote:
>
> Here's an updated patch.
>
>
> Thanks Alexei, getting better.  Minor nit picks:
>
> +//===--- InitPreprocessor.h - InitializePreprocessor function. --*- C++
> -*-===//
> ..
> +
> +#include "llvm/Support/CommandLine.h"
>
> Please don't include this here, it should just be in clang-cc.
> +#include <algorithm>
>
> This shouldn't be needed by the header.
>
>
> +++ lib/Frontend/InitPreprocessor.cpp (revision 0)
> @@ -0,0 +1,470 @@
> +//===--- InitPreprocessor.h - InitializePreprocessor function. --*- C++
> -*-===//
>
> Please fix comment line.
>
> +#include "llvm/Support/CommandLine.h"
>
> Please remove this and any other dead #includes from the .cpp.
>
>
> +// FIXME: -imacros
>
> We support imacros now, this can be removed :)
>
> Otherwise, looks great!
>
> -Chris
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20090421/21084f4f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: InitPP3.diff
Type: application/octet-stream
Size: 46011 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20090421/21084f4f/attachment.obj>