Done.<br><br><div class="gmail_quote">On Tue, Apr 21, 2009 at 1:26 AM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com">clattner@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

<div style="word-wrap:break-word"><br><div><div class="im"><div>On Apr 20, 2009, at 10:15 PM, Alexei Svitkine wrote:</div><br><blockquote type="cite">Here's an updated patch.</blockquote><div><br></div></div>Thanks Alexei, getting better.  Minor nit picks:</div>

<div><br></div><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">+//===--- InitPreprocessor.h - InitializePreprocessor function. --*- C++ -*-===//</div><div><font face="Monaco" size="2"><span style="font-size:10px">..</span></font></div>

<div><font face="Monaco" size="2"><span style="font-size:10px"><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">+</div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">

+#include "llvm/Support/CommandLine.h"</div><div><br></div><div>Please don't include this here, it should just be in clang-cc.</div><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">

+#include <algorithm></div><div><br></div><div>This shouldn't be needed by the header.</div><div><br></div></div><div><br></div><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">

+++ lib/Frontend/InitPreprocessor.cpp<span style="white-space:pre">     </span>(revision 0)</div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">@@ -0,0 +1,470 @@</div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">

+//===--- InitPreprocessor.h - InitializePreprocessor function. --*- C++ -*-===//</div><div><br></div><div>Please fix comment line.</div><div><br></div><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">

+#include "llvm/Support/CommandLine.h"</div><div><br></div><div>Please remove this and any other dead #includes from the .cpp.</div><div><br></div><div><br></div><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">

+// FIXME: -imacros</div><div><br></div><div>We support imacros now, this can be removed :)</div><div><br></div><div>Otherwise, looks great!</div><div><br></div><font color="#888888"><div>-Chris</div></font></div></div></div>

</span></font></div></div></div></blockquote></div><br>