[cfe-dev] thread class patch to llvm/system for clang distcc server
clattner at apple.com
Mon Aug 11 13:56:46 PDT 2008
On Aug 11, 2008, at 2:25 AM, Csaba Hruska wrote:
> Here is the second version of my patch to support platform
> independent threading required by clangserver.
This looks pretty reasonable to me, but do you really need
Thread::kill? Thread killing is a very touchy subject that often just
doesn't work right in many cases (e.g. dtors in killed threads are
often not run), it would be better to not depend on it.
Also, should the code in lib/System/Unix/Thread.inc call assert(0) or
abort since they aren't implemented yet (instead of being empty)?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-dev