[cfe-dev] Two style questions

[Chris Lattner]

On Nov 13, 2007, at 11:29 AM, Cédric Venet wrote:

>>> Attached the scoped_ptr extracted from boost (just modified the
>>> include
>>> style from <> to ""), there is some accessory (but useful) features
>>> which
>>> could be deleted as the complete_type delete checker.
>
>> Please cut this down significantly more.  We don't currently support
>> old versions of metrowerks or sunpro, so those and the boost
>> workaround stuff can all go away.  Also, instead of  BOOST_ASSERT,
>> please just use <cassert> and assert.  Please make it into a single
>> header that we can check into include/llvm/ADT.  Thanks!
>> -Chris=
>
> Here a new patch. I didn't know what to do for the license header,  
> so I let
> it as is.
> I also let the checked delete because pretty useful. The two free  
> function
> at the end: swap et get_pointer are only useful for generic  
> programming, I
> let then but don't know If it is really useful.

Sure, this looks great, very nice.

> The other header in ADT seems to use Camel notation for their class  
> name,
> should I rename scoped_ptr => ScopedPtr. Also the indentation is 4  
> spaces
> against the 2 of llvm, should this be corrected?

I don't have a problem with this.

Two requests:

First, please add the llvm copyright header and standard file prolog  
above the boost copyright blurb.

Second, please add an entry to the end of llvm/LICENSE.TXT with a  
pointer to the boost license.

Thanks Cédric!

-Chris