[cfe-dev] standard headers questions

Sean Middleditch sean at awesomeplay.com
Thu Dec 13 19:04:16 PST 2007


On Thu, 2007-12-13 at 17:44 -0800, Chris Lattner wrote:
> The include guard needs to start with _ to avoid polluting the user's  
> namespace.

Righty.  That was what the LLVM_CLANG_ bit was for, but an extra _ won't
hurt.  :)

> > Should there be more comments for the macro definitions
> > themselves, or are suitably small, simple, obvious, self-documenting
> > things like that acceptable to leave without description?
> 
> It would be nice to cite the standard for the various pieces :).   

Gotcha, will do.

> Where should this go in the clang tree?  I don't think putting it in  
> clang/include/... makes sense, how about a top level stdincludes  
> directory or something?

I was wondering about that.  How about std/c/ ?  Later on one could add
std/objc/, std/cxx/, etc as needed.

I was also wondering where these headers should be installed.  GCC puts
them in its own private target-specific path, but we're not doing the
target-specific header stuff.  Would $(prefix)/include/llvm/std/c/ be
acceptable, or what?

> 
> -Chris




More information about the cfe-dev mailing list