[clang] Revert "Revert "[OpenMP][TR12] change property of map-type modifier."… (PR #91141)

via cfe-commits cfe-commits at lists.llvm.org
Thu May 9 13:46:46 PDT 2024


jyu2-git wrote:

The test failed is due to the change following:  I had fixed the test in https://github.com/llvm/llvm-project/pull/91426.

commit e74a7a9fd79a74073277471243a44527c71eb4a9
Author: Fangrui Song <i at maskray.me>
Date:   Tue May 7 09:15:52 2024 -0700

    cc1: Report an error for multiple actions unless separated by -main-file-name (#91140)

    When multiple actions are specified, the last one is used and others are
    overridden. This might lead to confusion if the user is used to driver's
    `-S -emit-llvm` behavior.

    ```
    %clang_cc1 -S -emit-llvm a.c     # -S is overridden
    %clang_cc1 -emit-llvm -S a.c     # -emit-llvm is overridden
    %clang_cc1 -fsyntax-only -S a.c  # -fsyntax-only is overridden
    ```

    However, we want to continue supporting overriding the driver action
    with -Xclang:

    * `clang -c -Xclang -ast-dump a.c` (`%clang -cc1 -emit-obj ...
    -main-file-name a.c ... -ast-dump`)
    * `clang -c -xc++ -Xclang -emit-module stl.modulemap`

    As an exception, we allow -ast-dump* options to be composed together
    (e.g. `-ast-dump -ast-dump-lookups` in AST/ast-dump-lookups.cpp).


https://github.com/llvm/llvm-project/pull/91141


More information about the cfe-commits mailing list