[clang] [llvm] [ASAN] Add "sanitized_padded_global" llvm ir attribute to identify sanitizer instrumented globals (PR #68865)

via cfe-commits cfe-commits at lists.llvm.org
Thu May 9 09:06:05 PDT 2024


b-sumner wrote:

> > AMD language runtimes provide queries for the size of device global symbols and functions to copy data to and from device global variables. Currently, runtime gets the needed information form the ELF symbol sizes in the symbol table. So, in #70166 We have come up with approach of adding two symbols (at the same offset but with different sizes) for the same global, one symbol which reports actual global size and other symbol which reports instrumented size.
> 
> Have you looked into switching to the suggested approach of having a separately emitted field?

If you mean rewrite the runtime implementation, we have not.  There is nothing wrong with the runtime implementation, and I'm still not understanding the concern being raised about the approach here which has been running without issue for many months.

https://github.com/llvm/llvm-project/pull/68865


More information about the cfe-commits mailing list