[clang-tools-extra] aeab44d - [NFC][clang-tidy] remove magic-numbers-todo.cpp (#91577)

via cfe-commits cfe-commits at lists.llvm.org
Thu May 9 08:59:23 PDT 2024


Author: Congcong Cai
Date: 2024-05-09T23:59:11+08:00
New Revision: aeab44d3861dbaac1eb8d68d818f432c86322759

URL: https://github.com/llvm/llvm-project/commit/aeab44d3861dbaac1eb8d68d818f432c86322759
DIFF: https://github.com/llvm/llvm-project/commit/aeab44d3861dbaac1eb8d68d818f432c86322759.diff

LOG: [NFC][clang-tidy] remove magic-numbers-todo.cpp (#91577)

This XFAIL test is written in 4 years ago and still todo.
4 is already in DefaultIgnoredIntegerValues so I do not think this XFAIL
case can be passed.

Added: 
    

Modified: 
    

Removed: 
    clang-tools-extra/test/clang-tidy/checkers/readability/magic-numbers-todo.cpp


################################################################################
diff  --git a/clang-tools-extra/test/clang-tidy/checkers/readability/magic-numbers-todo.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/magic-numbers-todo.cpp
deleted file mode 100644
index 99d9be262a897..0000000000000
--- a/clang-tools-extra/test/clang-tidy/checkers/readability/magic-numbers-todo.cpp
+++ /dev/null
@@ -1,15 +0,0 @@
-// RUN: %check_clang_tidy %s readability-magic-numbers %t --
-// XFAIL: *
-
-int ProcessSomething(int input);
-
-int DoWork()
-{
-  if (((int)4) > ProcessSomething(10))
-  // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: 4 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
-    return 0;
-
-   return 0;
-}
-
-


        


More information about the cfe-commits mailing list