[clang] [llvm] [WebAssembly] Implement prototype f32.store_f16 instruction. (PR #91545)

Heejin Ahn via cfe-commits cfe-commits at lists.llvm.org
Wed May 8 18:28:19 PDT 2024


================
@@ -171,12 +171,16 @@ defm STORE8_I64 : WebAssemblyStore<I64, "i64.store8", 0x3c>;
 defm STORE16_I64 : WebAssemblyStore<I64, "i64.store16", 0x3d>;
 defm STORE32_I64 : WebAssemblyStore<I64, "i64.store32", 0x3e>;
 
+defm STORE_F16_F32 : WebAssemblyStore<F32, "f32.store_f16", 0xfc31, [HasHalfPrecision]>;
----------------
aheejin wrote:

```suggestion
// Half-precision store.
defm STORE_F16_F32 :
  WebAssemblyStore<F32, "f32.store_f16", 0xfc31, [HasHalfPrecision]>;
```
How about adding one-line comment? The same for `LOAD` too.
Also 80-col wrapping.

https://github.com/llvm/llvm-project/pull/91545


More information about the cfe-commits mailing list