[clang] [HLSL] Support packoffset attribute in AST (PR #89836)

Chris B via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 07:17:39 PDT 2024


================
@@ -4372,6 +4372,13 @@ def HLSLResourceBinding: InheritableAttr {
   let Documentation = [HLSLResourceBindingDocs];
 }
 
+def HLSLPackOffset: HLSLAnnotationAttr {
+  let Spellings = [HLSLAnnotation<"packoffset">];
+  let LangOpts = [HLSL];
+  let Args = [IntArgument<"Offset">];
----------------
llvm-beanz wrote:

The feedback here still isn't resolved. The argument is an IdentifierArgument with special parsing handling, it isn't an integer. We can store the parsed integer values in the attribute but we shouldn't be calling the argument an IntArgument.

https://github.com/llvm/llvm-project/pull/89836


More information about the cfe-commits mailing list