[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

David Truby via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 06:29:08 PDT 2024


DavidTruby wrote:

> The code checks whether the directory is present `auto CRTPath = TC.getCompilerRTPath();` and only adds the libpath when it is present. This is related to the `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=off` file hierarchy we are migrating way from.
> 
> With `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on`, TC.getCompilerRTPath() will not be needed.
> 
> Since there is no good way to test this, I'm fine with the patch without a test.

Hi, I'm not sure I understand exactly what you mean by without a test; do you mean I should just remove the tests I tried to add or is there some extra behaviour that you're talking about that can't be tested?

https://github.com/llvm/llvm-project/pull/90758


More information about the cfe-commits mailing list