[clang] [RISCV][NFC] Remove redundant test cases. (PR #91324)

via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 06:11:38 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-risc-v

Author: Yeting Kuo (yetingk)

<details>
<summary>Changes</summary>

PR #<!-- -->89727 added the two test cases to verify `.option arch` should only work when having -menable-experimental-extensions. And the test idea could be splitted to
1. When having menable-experimental-extensions, clang passes +experimental.
2. `.option arch` only enabled when +experimental enabled. 

And we already had the two kind of tests.

---
Full diff: https://github.com/llvm/llvm-project/pull/91324.diff


2 Files Affected:

- (removed) clang/test/Driver/riscv-option-arch.c (-8) 
- (removed) clang/test/Driver/riscv-option-arch.s (-6) 


``````````diff
diff --git a/clang/test/Driver/riscv-option-arch.c b/clang/test/Driver/riscv-option-arch.c
deleted file mode 100644
index 9f0e037cd12e0..0000000000000
--- a/clang/test/Driver/riscv-option-arch.c
+++ /dev/null
@@ -1,8 +0,0 @@
-// REQUIRES: riscv-registered-target
-// RUN: %clang --target=riscv64 -menable-experimental-extensions -c -o /dev/null %s
-// RUN: ! %clang --target=riscv64 -c -o /dev/null %s 2>&1 | FileCheck -check-prefixes=CHECK-ERR %s
-
-void foo() {
-  asm volatile (".option arch, +zicfiss");
-  // CHECK-ERR: Unexpected experimental extensions.
-}
diff --git a/clang/test/Driver/riscv-option-arch.s b/clang/test/Driver/riscv-option-arch.s
deleted file mode 100644
index c4ca4aa459ce2..0000000000000
--- a/clang/test/Driver/riscv-option-arch.s
+++ /dev/null
@@ -1,6 +0,0 @@
-# REQUIRES: riscv-registered-target
-# RUN: %clang --target=riscv64 -menable-experimental-extensions -c -o /dev/null %s
-# RUN: ! %clang --target=riscv64 -c -o /dev/null %s 2>&1 | FileCheck -check-prefixes=CHECK-ERR %s
-
-.option arch, +zicfiss
-# CHECK-ERR: Unexpected experimental extensions.

``````````

</details>


https://github.com/llvm/llvm-project/pull/91324


More information about the cfe-commits mailing list