[clang] [Clang] Propagate 'SystemDrive' environment variable for unit tests (PR #90478)

Krystian Stasiowski via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 29 09:21:38 PDT 2024


https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/90478

>From b52984893c1f83963f90c4784e17f4cf2243e046 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Mon, 29 Apr 2024 10:01:14 -0400
Subject: [PATCH 1/2] [Clang] Propagate 'SystemDrive' environment variable for
 unit tests

---
 clang/test/Unit/lit.cfg.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/clang/test/Unit/lit.cfg.py b/clang/test/Unit/lit.cfg.py
index 475069e630d74e..265e90968febb0 100644
--- a/clang/test/Unit/lit.cfg.py
+++ b/clang/test/Unit/lit.cfg.py
@@ -32,6 +32,8 @@
 
 if "HOME" in os.environ:
     config.environment["HOME"] = os.environ["HOME"]
+if "SystemDrive" in os.environ:
+    config.environment["SystemDrive"] = os.environ["SystemDrive"]
 
 # Propagate sanitizer options.
 for var in [

>From fd868227ff517ecfd05b7e77b4cb72577fef6c2f Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Mon, 29 Apr 2024 12:21:26 -0400
Subject: [PATCH 2/2] [FOLD] address review feedback

---
 clang/test/Unit/lit.cfg.py | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/clang/test/Unit/lit.cfg.py b/clang/test/Unit/lit.cfg.py
index 265e90968febb0..37e91d0f8629f9 100644
--- a/clang/test/Unit/lit.cfg.py
+++ b/clang/test/Unit/lit.cfg.py
@@ -25,15 +25,9 @@
 
 # Propagate the temp directory. Windows requires this because it uses \Windows\
 # if none of these are present.
-if "TMP" in os.environ:
-    config.environment["TMP"] = os.environ["TMP"]
-if "TEMP" in os.environ:
-    config.environment["TEMP"] = os.environ["TEMP"]
-
-if "HOME" in os.environ:
-    config.environment["HOME"] = os.environ["HOME"]
-if "SystemDrive" in os.environ:
-    config.environment["SystemDrive"] = os.environ["SystemDrive"]
+for v in ["TMP", "TEMP", "HOME", "SystemDrive"]:
+    if v in os.environ:
+        config.environment[v] = os.environ[v]
 
 # Propagate sanitizer options.
 for var in [



More information about the cfe-commits mailing list