[clang] Don't wrap immediate invocations in ConstantExprs within constexpr initializers (PR #89565)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 29 07:30:54 PDT 2024


================
@@ -16548,11 +16548,10 @@ static void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
         std::string PrettySourceValue = toString(Value, 10);
         std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
 
-        S.DiagRuntimeBehavior(
-            E->getExprLoc(), E,
-            S.PDiag(diag::warn_impcast_integer_precision_constant)
-                << PrettySourceValue << PrettyTargetValue << E->getType() << T
-                << E->getSourceRange() << SourceRange(CC));
----------------
erichkeane wrote:

Its a warning, of course the standard doesn't require it.  It seems to me that it is a USEFUL diagnostic though.

https://github.com/llvm/llvm-project/pull/89565


More information about the cfe-commits mailing list