[clang] bb1a8bb - [NFC][OpenACC] Remove stale FIXME comment in a test

via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 26 06:17:55 PDT 2024


Author: erichkeane
Date: 2024-04-26T06:17:05-07:00
New Revision: bb1a8bbbf06f4cbe66b685b068add5ae63c21697

URL: https://github.com/llvm/llvm-project/commit/bb1a8bbbf06f4cbe66b685b068add5ae63c21697
DIFF: https://github.com/llvm/llvm-project/commit/bb1a8bbbf06f4cbe66b685b068add5ae63c21697.diff

LOG: [NFC][OpenACC] Remove stale FIXME comment in a test

A recent patch changed the array sections to work differently for
OpenACC, including for the diagnostic, so the FIXME is now irrelevant.

Added: 
    

Modified: 
    clang/test/ParserOpenACC/parse-cache-construct.cpp

Removed: 
    


################################################################################
diff  --git a/clang/test/ParserOpenACC/parse-cache-construct.cpp b/clang/test/ParserOpenACC/parse-cache-construct.cpp
index 1ab2153a68be8d..f1c71e8b584786 100644
--- a/clang/test/ParserOpenACC/parse-cache-construct.cpp
+++ b/clang/test/ParserOpenACC/parse-cache-construct.cpp
@@ -72,8 +72,6 @@ void use() {
     #pragma acc cache(Arrs.MemArr[3].array[1:4])
   }
   for (int i = 0; i < 10; ++i) {
-    // FIXME: Once we have a new array-section type to represent OpenACC as
-    // well, change this error message.
     // expected-error at +2{{OpenACC sub-array is not allowed here}}
     // expected-warning at +1{{OpenACC construct 'cache' not yet implemented, pragma ignored}}
     #pragma acc cache(Arrs.MemArr[3:4].array[1:4])


        


More information about the cfe-commits mailing list