[clang] [Driver] Restore compiler-rt arch suffix for PS and Windows (PR #89775)

[Paul T Robinson via cfe-commits]

pogo59 wrote:

> My recollection of the past discussions is that we want users to switch to the new hierarchy. 

Is Microsoft a "user" who agreed to this change? Was clang-vendors tagged on this discussion about a new file hierarchy? I don't recall it. The library name change is news to me, although if it took place in a Discourse category that I don't follow, possibly our sanitizer folks are aware and I am not.

> `ToolChain::getCompilerRT` detects both the old and new compiler-rt directory. Does it not work for PlayStation?

I probably should not have pulled the PlayStation bit into it. The situation I ran into is a distributed build using a fresh-built clang-cl and the Visual Studio libraries in order to build a Windows app with `-fsanitize`. (PlayStation might have a similar issue, I haven't fully investigated that yet. I think it is likely though.)

> I am not aware of the embedded directive? Do you embed a path to a compiler-rt library to the generated object files?

Not a full path, but a filename. I see @mstorsjo has a comment also along these lines. The filename is searched for on the usual library paths, which aren't necessarily known or available to the compiler.

https://github.com/llvm/llvm-project/pull/89775