[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 16 05:07:30 PDT 2023


aaron.ballman added a comment.

In D131307#4197789 <https://reviews.llvm.org/D131307#4197789>, @erichkeane wrote:

> In D131307#4197767 <https://reviews.llvm.org/D131307#4197767>, @rsmith wrote:
>
>>> Based on feedback we will provide users to the ability to downgrade this this diagnostic to a waring to allow for a transition period. We expect to turn this diagnostic to an error in the next release.
>>
>> Can we revert this now?
>
> Seems appropriate.  Aaron, WDYT?

I think it's fine -- if we get significant user feedback after 16 goes out to the public which suggests we need to retain this for longer, it's easy enough to bring back from version control.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131307/new/

https://reviews.llvm.org/D131307



More information about the cfe-commits mailing list