[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

[Takuya Shimizu via Phabricator via cfe-commits]

hazohelet updated this revision to Diff 504697.
hazohelet added a comment.

Address comments from @aaron.ballman

- Dropped `const` qualifier from value objects for style consistency
- Passed boolean `HasFallThroughAttr` to callback and handled warning suppression in `HandleUnreachable` in order to make code cleaner.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145842/new/

https://reviews.llvm.org/D145842

Files:
  clang/include/clang/Analysis/Analyses/ReachableCode.h
  clang/lib/Analysis/ReachableCode.cpp
  clang/lib/Sema/AnalysisBasedWarnings.cpp
  clang/test/Sema/warn-unreachable-fallthrough.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145842.504697.patch
Type: text/x-patch
Size: 4685 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230313/c5666289/attachment.bin>