[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

Fri Mar 10 11:43:37 PST 2023

lamb-j added a comment.

In D145770#4184996 <https://reviews.llvm.org/D145770#4184996>, @yaxunl wrote:

> The description needs fix. "ABI field" should be "environment component".
>
> Also, we need a clang-offload-bundler test which bundles with a non-canonical triple and unbundles with a canonical triple and vice versa.

I'm not sure if we can use Triple.normalize(). Here's what I got from a small test:

  amdgcn-amd-amdhsa  ->  amdgcn-amd-amdhsa (no env field added)
  amdgcn-amd-amdhsa- ->  amdgcn-amd-amdhsa-unknown (empty env changed to unknown)

Also are we sure ABI is incorrect? That's what is used here:

https://clang.llvm.org/docs/CrossCompilation.html

(I'm happy to change to environment, just double checking)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145770/new/

https://reviews.llvm.org/D145770