[PATCH] D145435: Choose style (file) from within code for use in IDEs

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 9 17:46:15 PST 2023


owenpan added a comment.

In D145435#4181215 <https://reviews.llvm.org/D145435#4181215>, @HazardyKnusperkeks wrote:

> Although I don't think I will use that feature, I still think it might be useful and doesn't really hurt anyone.

It would add extra runtime (especially for large files). We would also run the risk of regressions (though unlikely) if for whatever reason an existing codebase has files starting with `// clang-format style=`.

I'm still of the opinion that if this is not highly demanded (yet) and can be done outside of clang-format, we should not add this feature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145435/new/

https://reviews.llvm.org/D145435



More information about the cfe-commits mailing list