[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added a comment.

In D124351#4175717 <https://reviews.llvm.org/D124351#4175717>, @sammccall wrote:

> We're seeing new clang crashes that bisect to this commit, with modules only.
>
> I have it mostly-reduced and will post shortly, trying to see if I can simplify any further (since modules reproducers are a pain).
>
> Meanwhile, the assert/stack in case it's already useful:
>
>   assertion failed at third_party/llvm/llvm-project/clang/lib/Sema/SemaTemplateInstantiate.cpp:4065 in llvm::PointerUnion<Decl *, LocalInstantiationScope::DeclArgumentPack *> *clang::LocalInstantiationScope::findInstantiationOf(const Decl *): isa<LabelDecl>(D) && "declaration not instantiated in this scope"
>   *** Check failure stack trace: ***
>       @     0x5609e4f16f44  __assert_fail
>       @     0x5609e1894234  clang::LocalInstantiationScope::findInstantiationOf()
>       @     0x5609e18d073c  clang::Sema::FindInstantiatedDecl()
>       @     0x5609e18a99d0  clang::TreeTransform<>::TransformLambdaExpr()
>       @     0x5609e189dbee  (anonymous namespace)::TemplateInstantiator::TransformLambdaExpr()
>       @     0x5609e1892442  clang::TreeTransform<>::TransformExprs()
>       @     0x5609e189a71a  clang::TreeTransform<>::TransformCallExpr()
>       @     0x5609e189097a  clang::TreeTransform<>::TransformStmt()
>       @     0x5609e18afa54  clang::TreeTransform<>::TransformCompoundStmt()
>       @     0x5609e1890902  clang::Sema::SubstStmt()
>       @     0x5609e18e31df  clang::Sema::InstantiateFunctionDefinition()
>       @     0x5609e18e5ed2  clang::Sema::PerformPendingInstantiations()
>       @     0x5609e0fcad44  clang::Sema::ActOnEndOfTranslationUnitFragment()
>       @     0x5609e0fcbb66  clang::Sema::ActOnEndOfTranslationUnit()
>       @     0x5609e0d298e6  clang::Parser::ParseTopLevelDecl()
>       @     0x5609e0d2388e  clang::ParseAST()
>       @     0x5609e0a647c3  clang::FrontendAction::Execute()
>       @     0x5609e09d81ad  clang::CompilerInstance::ExecuteAction()
>       @     0x5609dfa05b08  clang::ExecuteCompilerInvocation()
>       @     0x5609df9f99f1  cc1_main()
>       @     0x5609df9f5d28  ExecuteCC1Tool()
>       @     0x5609e0b868be  llvm::function_ref<>::callback_fn<>()
>       @     0x5609e4d9ec35  llvm::CrashRecoveryContext::RunSafely()
>       @     0x5609e0b86103  clang::driver::CC1Command::Execute()
>       @     0x5609e0b44166  clang::driver::Compilation::ExecuteCommand()
>       @     0x5609e0b4448f  clang::driver::Compilation::ExecuteJobs()
>       @     0x5609e0b63e70  clang::driver::Driver::ExecuteCompilation()
>       @     0x5609df9f4ee7  clang_main()
>       @     0x5609df9f1bc4  main
>       @     0x7fad2cda4633  __libc_start_main
>       @     0x5609df9f1b2a  _start

Thanks for letting me know.
A reproduction will be very useful to track that down indeed, I'll look into it as soon as i hear back from you. The stack trace doesn't tell me much unfortunately, although it definitely appears related.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124351/new/

https://reviews.llvm.org/D124351