[PATCH] D145364: [include-cleaner] Fix a crash on non-identifier-name symbols.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 6 02:53:53 PST 2023


hokein added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/test/nocrash.cpp:1
+// RUN: clang-include-cleaner %s --
+
----------------
I have considered to add a unittest in `FindHeadersTest`, but that is not trivial to do, the unittest is written based on the assumption that the captured symbol name is a simple identifier (we use the it to find the symbol based on a given text name).

Other ideas are welcome.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145364/new/

https://reviews.llvm.org/D145364



More information about the cfe-commits mailing list