[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

Mon Feb 27 07:46:55 PST 2023

jhuber6 added a comment.

I would prefer that this doesn't get reverted, see the summary for the awful results for OpenMP without this patch. A potential solution would be to parse the next token and only add the indent if it's `omp`.

================
Comment at: clang/unittests/Format/FormatTest.cpp:5175
   verifyFormat("#pragma omp threadprivate( \\\n"
-               "    y)), // expected-warning",
+               "        y)), // expected-warning",
                getLLVMStyleWithColumns(28));
----------------
owenpan wrote:
> Why was this test case changed? It seemed to be related to the regression mentioned in D136100#3988574.
It's definitely related, we want some indentation for successive OpenMP clauses pushed to a new line, see below.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136100/new/

https://reviews.llvm.org/D136100