[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 23 18:23:37 PST 2023


shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaConcept.cpp:537
+    if (!CapturedPattern->isParameterPack()) {
+      ValueDecl *CapturedVar =
+          LambdaClass->getCapture(Instantiated)->getCapturedVar();
----------------
This is just duplicated across the `if` and `else`, please refactor it out. If this ever gets modified folks have to fix it in both places and that is easy to mess up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124351/new/

https://reviews.llvm.org/D124351



More information about the cfe-commits mailing list