[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 22 11:08:53 PST 2023


owenpan accepted this revision.
owenpan added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:284-285
+    // However,  `const Bar::*` remains the same.
+    while (Next && Next->isOneOf(tok::identifier, tok::coloncolon) &&
+           !Next->startsSequence(tok::coloncolon, tok::star)) {
       Next = Next->Next;
----------------
Or:
```
while (Next && (Next->is(tok::identifier) || (Next->is(tok::coloncolon) &&
           (!Next->Next || Next->Next->isNot(tok::star))))) {
```
Nevertheless, I'm okay if you don't make any change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144537/new/

https://reviews.llvm.org/D144537



More information about the cfe-commits mailing list