[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

[Piotr Zegar via Phabricator via cfe-commits]

PiotrZSL added a comment.

I don't know why but with latest version I still got false positive with std::function on Clang 15.

  using Functor= std::function<... something ...>;
  
  std::unique_ptr Class::createSomething(::Functor&& functor) {
     return std::make_unique<SomeType>(std::move(functor));
  }



================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:41
+                                                   unless(isMoveConstructor()),
+                                                   isDefinition(), ToParam)
+                                    .bind("containing-ctor")),
----------------
duplicated isDefinition and ToParam


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141569/new/

https://reviews.llvm.org/D141569