[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

[Serge Pavlov via Phabricator via cfe-commits]

sepavloff added inline comments.


================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:824
+      continue;
+    }
+
----------------
efriedma wrote:
> sepavloff wrote:
> > efriedma wrote:
> > > Is this necessary?  The non-delayed-parsed case seems to work correctly on trunk without any changes, so I suspect the autogenerated sema::instantiateTemplateAttribute is doing the right thing.
> > Yes, it is necessary. Without it the code from the added test crashes, as constrained intrinsic is used in a function without strictfp attribute.
> https://godbolt.org/z/MvPrejY75 indicates this is only an issue with -fdelayed-template-parsing; am I missing something?
Indeed. I used Windows where this flag is on by default. Thank you for the catch.
Removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143919/new/

https://reviews.llvm.org/D143919