[PATCH] D143670: Stop claiming we support [[carries_dependency]]

Nikolas Klauser via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 9 11:34:51 PST 2023


philnik added a comment.

In D143670#4116118 <https://reviews.llvm.org/D143670#4116118>, @cor3ntin wrote:

> Thanks for doing this Aaron.
> Did you look in libc++ if they used it anywhere? (I assume they don't)

I'm not aware of any uses, and I would be quite surprised if it was used anywhere given that apparently nobody properly implemented it. IIUC this attribute is supposed to improve performance in some way, and we normally require a benchmark to show that some change actually does that if it claims to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143670/new/

https://reviews.llvm.org/D143670



More information about the cfe-commits mailing list