[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 6 00:54:41 PST 2023


kadircet added inline comments.


================
Comment at: clang/include/clang/Tooling/Inclusions/CXXSymbolMap.inc:1
+//===-- CXXSymbolMap.inc ----------------------------------------*- C++ -*-===//
+//
----------------
also maybe rename this to, `AlternativeHeaderMap.inc` ?


================
Comment at: clang/include/clang/Tooling/Inclusions/CXXSymbolMap.inc:3
+//
+// Unlike the generated StdSymbolMap.inc, this file contains a hand-cruted list
+// of symbols (which are hard to handle by the generator script). It intends
----------------
i'd rather say `This is a hand-curated list for symbols provided by multiple headers, to address the short comings of cppreference or automated extraction logic. All entries for a symbol name provide the same declaration (hence these are not overloads/variants like std::remove from algorithm vs cstdio).`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143160/new/

https://reviews.llvm.org/D143160



More information about the cfe-commits mailing list