[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 5 10:22:31 PST 2023


carlosgalvezp added a comment.

Please document change in Release Notes, as well as in the check documentation, together with its limitations (can only handle 1 argument at a time).



================
Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:182
+
+  Finder->addMatcher(
+      traverse(TK_AsIs,
----------------
Nit: add a comment explaining what this matcher does, for consistency with how it's done with the other matchers above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143342/new/

https://reviews.llvm.org/D143342



More information about the cfe-commits mailing list